Resolve "Adjustments using adjust require the input data of the control period to have the same size for the time dimension"
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 98.08% 97.14% -0.95%
==========================================
Files 7 7
Lines 261 280 +19
==========================================
+ Hits 256 272 +16
- Misses 5 8 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@Pan-Yuxian have a look; could you please try this change set on your data? |
Thank you @btschwertfeger ! |
btschwertfeger
deleted the
66-adjustments-using-adjust-require-the-input-data-of-the-control-period-to-have-the-same-size-for-the-time-dimension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion on #65 has shown an error that occurs, when using a workaround to adjust a data set based on control period data with differently shaped time-dimensions.
So the first issue that this PR is addressing is to enable to use differently sized control period data for the adjustment. From now on, the time dimension of the modeled data of the control period must not have the same length as the time dimension of the reference data of the control period.
The main issue that the mentioned discussion is about, is a strange result when applying the methods to un-evenly shaped data. The problem is described in more detail in How to deal with obs and simh if they have different time lengths? #65 (reply in thread). So to fix this, we now interpolate the cumulative distribution functions of the modeled data of the control period to the value range of the passed reference data.
Since the second issue was not present in this package, as it was only visible when just copying or hacking around, a single feature PR is sufficient, no further issues must be created.