Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Add start, end, and cursor parameters to kraken.spot.Funding.get_recent_withdraw_status" #177

Conversation

btschwertfeger
Copy link
Owner

PR that adds the mentioned parameters to the mentioned function.

@btschwertfeger btschwertfeger added enhancement New feature or request Spot Topic related to Spot trading labels Dec 6, 2023
@btschwertfeger btschwertfeger added this to the Future Release milestone Dec 6, 2023
@btschwertfeger btschwertfeger self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #177 (498872d) into master (93cd118) will decrease coverage by 2.61%.
Report is 1 commits behind head on master.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   90.40%   87.79%   -2.61%     
==========================================
  Files          21       21              
  Lines        1845     1877      +32     
==========================================
- Hits         1668     1648      -20     
- Misses        177      229      +52     
Flag Coverage Δ
unittests 87.79% <50.00%> (-2.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
kraken/base_api/__init__.py 89.65% <100.00%> (-0.30%) ⬇️
kraken/futures/trade.py 96.20% <100.00%> (ø)
kraken/futures/user.py 48.48% <100.00%> (-37.88%) ⬇️
kraken/spot/__init__.py 100.00% <ø> (ø)
kraken/spot/trade.py 94.33% <100.00%> (ø)
kraken/spot/user.py 99.12% <100.00%> (ø)
kraken/spot/websocket_v1.py 97.16% <100.00%> (ø)
kraken/spot/funding.py 46.57% <7.14%> (-24.54%) ⬇️

@btschwertfeger btschwertfeger merged commit 69ed6a0 into master Dec 6, 2023
20 of 27 checks passed
@btschwertfeger btschwertfeger deleted the 176-add-start-end-and-cursor-parameters-to-krakenspotwithdraw_status branch December 6, 2023 21:47
@btschwertfeger btschwertfeger changed the title Add start, end, and cursor parameters to kraken.spot.Funding.get_recent_withdraw_status Resolve "Add start, end, and cursor parameters to kraken.spot.Funding.get_recent_withdraw_status" Dec 7, 2023
btschwertfeger added a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Spot Topic related to Spot trading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add start, end, and cursor parameters to kraken.spot.Funding.get_recent_withdraw_status
1 participant