Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Add kraken.futures.Trade.get_max_order_size" #193

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

btschwertfeger
Copy link
Owner

Add the new endpoint as well as a test for that.

This PR is blocked until #189 is merged.

@btschwertfeger btschwertfeger added enhancement New feature or request Futures Topic related to Futures trading labels Feb 21, 2024
@btschwertfeger btschwertfeger added this to the Future Release milestone Feb 21, 2024
@btschwertfeger btschwertfeger self-assigned this Feb 21, 2024
@btschwertfeger btschwertfeger linked an issue Feb 21, 2024 that may be closed by this pull request
@btschwertfeger btschwertfeger marked this pull request as draft March 1, 2024 17:48
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.49%. Comparing base (3f53ec7) to head (696b0b6).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   89.46%   89.49%   +0.02%     
==========================================
  Files          21       21              
  Lines        1879     1884       +5     
==========================================
+ Hits         1681     1686       +5     
  Misses        198      198              
Flag Coverage Δ
unittests 89.49% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
kraken/futures/trade.py 95.23% <100.00%> (+0.30%) ⬆️

@btschwertfeger btschwertfeger marked this pull request as ready for review March 9, 2024 07:33
@btschwertfeger btschwertfeger merged commit 87f0396 into master Mar 9, 2024
32 checks passed
@btschwertfeger btschwertfeger deleted the 190-add-krakenfuturestradeget_max_order_size branch March 9, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Futures Topic related to Futures trading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kraken.futures.Trade.get_max_order_size
1 participant