Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Mark kraken.spot.Staking as deprecated and add kraken.spot.Earn" #199

Conversation

btschwertfeger
Copy link
Owner

  • The Staking endpoints were marked as deprecated and will be removed in a future release.
  • The new Earn client was added with all its current endpoints.

@btschwertfeger btschwertfeger added enhancement New feature or request Spot Topic related to Spot trading labels Mar 9, 2024
@btschwertfeger btschwertfeger added this to the Future Release milestone Mar 9, 2024
@btschwertfeger btschwertfeger self-assigned this Mar 9, 2024
@btschwertfeger btschwertfeger linked an issue Mar 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 64.19753% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 88.41%. Comparing base (3f53ec7) to head (63918a4).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   89.46%   88.41%   -1.06%     
==========================================
  Files          21       24       +3     
  Lines        1879     1959      +80     
==========================================
+ Hits         1681     1732      +51     
- Misses        198      227      +29     
Flag Coverage Δ
unittests 88.41% <64.19%> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
kraken/base_api/__init__.py 89.06% <ø> (ø)
kraken/exceptions/__init__.py 99.29% <100.00%> (+0.09%) ⬆️
kraken/spot/__init__.py 100.00% <100.00%> (ø)
kraken/spot/funding.py 46.57% <ø> (ø)
kraken/spot/market.py 100.00% <ø> (ø)
kraken/spot/staking.py 65.62% <100.00%> (+9.62%) ⬆️
kraken/spot/trade.py 94.33% <ø> (ø)
kraken/spot/user.py 99.12% <ø> (ø)
kraken/utils/__init__.py 100.00% <100.00%> (ø)
kraken/utils/utils.py 83.33% <83.33%> (ø)
... and 1 more

@btschwertfeger btschwertfeger merged commit c1e6f78 into master Mar 9, 2024
32 checks passed
@btschwertfeger btschwertfeger deleted the 196-mark-krakenspotstaking-as-deprecated-and-add-krakenspotearn branch March 9, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Spot Topic related to Spot trading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark kraken.spot.Staking as deprecated and add kraken.spot.Earn
1 participant