Resolve "Mark kraken.spot.KrakenSpotWSClientV1 as deprecated"
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 88.44% 88.45% +0.01%
==========================================
Files 24 24
Lines 1973 1975 +2
==========================================
+ Hits 1745 1747 +2
Misses 228 228
Flags with carried forward coverage won't be shown. Click here to find out more.
|
btschwertfeger
deleted the
138-introduce-the-deprecated-decorator-to-mark-spot-websocket-api-v1-as-deprecated
branch
btschwertfeger
added a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the related issue notes - the websocket API v1 will most probably be replaced by API v2, so marking it as deprecated is required.