New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there a Less version ? #26
Comments
Nope. Can you tell me why I should use Less instead of SCSS? |
Because Bootstrap uses Less ? I thought it was weird to use Scss in the first place. I think bootstrap-switch is great and should belong to Bootstrap :-) |
Yeah, we would love to have a .Less file that uses bootstrap variables so we can just build it with our styles, instead of string replacing/overriding the duplicate colors/themes. A lot like: https://github.com/eternicode/bootstrap-datepicker |
Ok, can you check out this branch? If it's ok I'll merge it to master. |
@iesta @markmarkoh can you give me feedback please? |
@nostalgiaz sorry! I checked out the branch last week and added an @import into our bootstrap.less (and removed the variables/mixin @imports), everything worked great. All of our variables were brought in and bootstrap-switch was styled automatically to match our theme. Very cool for you to do this, thanks. Are you planning to maintain both the .scss and .less? (FTR, I have nothing against .scss, I just love the idea of bootstrap UI widgets being so compatible). |
I don't think I have the time to maintain both the .scss and .less. My idea is to merge .less to master and say goodbye to .scss :P |
Possibly, here's what I did: https://github.com/markmarkoh/bootstrap-switch/tree/features/less/static/less styles.less brings in variables/mixins if necessary. For teams that throw boostrapSwitch.less into their build, they can just move that file. I don't have enough knowledge of other team's workflows to make to know whether or not this is useful for them. @iesta, thoughts? |
Works great for me too asis. Now I'll try to get it working in the rails asset pipeline. For some reason, something is not working. Thanks for the fast response. |
i was just running into this today. I do find having the deps folder there messy. |
My branch gets around the deps folder a bit.
|
that would work for me. thanks @markmarkoh! could you get a pull over here? |
Here we go! 583032b Goodbye scss, welcome less :) |
@markmarkoh can you fix the code and then send us a pull request? |
Is there any reason why the source uses SCSS ?
The text was updated successfully, but these errors were encountered: