Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative log likelihood loss and its derivative and add unit tests #16

Merged
merged 1 commit into from Aug 26, 2016

Conversation

Hydrotoast
Copy link
Contributor

Looks like I was missing a negative sign on the derivative for nlogsig_deriv. Integrating this should give us nlogsig, the negative log likelihood.

Should be noted somewhere that labels are intended to be of the form {-1, 1} for correctness. Otherwise, we can transform the labels when the classification task is chosen.

@coveralls
Copy link

coveralls commented Aug 24, 2016

Coverage Status

Coverage increased (+0.9%) to 97.414% when pulling 770fb27 on Hydrotoast:master into 1ea355a on btwardow:master.

@btwardow
Copy link
Owner

lgtm

@btwardow btwardow merged commit 96f30b0 into btwardow:master Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants