Fix negative log likelihood loss and its derivative and add unit tests #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I was missing a negative sign on the derivative for
nlogsig_deriv
. Integrating this should give usnlogsig
, the negative log likelihood.Should be noted somewhere that labels are intended to be of the form
{-1, 1}
for correctness. Otherwise, we can transform the labels when the classification task is chosen.