Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reakit #165

Closed
5 of 8 tasks
btzr-io opened this issue Oct 25, 2019 · 9 comments
Closed
5 of 8 tasks

Implement reakit #165

btzr-io opened this issue Oct 25, 2019 · 9 comments

Comments

@btzr-io
Copy link
Owner

btzr-io commented Oct 25, 2019

Creating core components like buttons and tooltip is becoming hard to maintain and takes a lot of time to integrate accessibility (WIA-ARIA standars):

We should use an existent solution to handle this, right now reakit seems the way to go, but I'm open for ideas.

See: https://github.com/reakit/reakit

⚠️ Note: if you want to help with this issue feel free to open one pull request peer component at a time. Multiple pr accepted.

@Tarektouati
Copy link

i'll do it , can you assign me to this ?

@btzr-io
Copy link
Owner Author

btzr-io commented Oct 25, 2019

@Tarektouati sure 👍

@btzr-io
Copy link
Owner Author

btzr-io commented Oct 25, 2019

Please read the note at the bottom ^^

@btzr-io
Copy link
Owner Author

btzr-io commented Oct 26, 2019

@Tarektouati Let me know if you have any questions ✌️

@Tarektouati
Copy link

@Btz-io okay i’ll do a PR components 😊

@btzr-io
Copy link
Owner Author

btzr-io commented Oct 28, 2019

@Tarektouati I did some progress with the menu, tooltips are a priority due the current component causing alot of issues, let me know if you can start with that ✌️

@Tarektouati
Copy link

@btzr-io Yes of course, i'll start with tooltips refacto today !

@Tarektouati
Copy link

@btzr-io I've submitted a PR waiting for review pls , let me know if i did something wrong before i start working on an other component 😄

@btzr-io btzr-io reopened this Oct 29, 2019
@btzr-io
Copy link
Owner Author

btzr-io commented Oct 29, 2019

Update on tooltip, see: #185 (comment)

btzr-io added a commit that referenced this issue Nov 2, 2019
@btzr-io btzr-io unpinned this issue Dec 3, 2019
@btzr-io btzr-io closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants