Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider merging OpenDialog, OpenDialogMultiple, and PickFolder into a single API #98

Closed
btzy opened this issue Apr 20, 2023 · 1 comment
Milestone

Comments

@btzy
Copy link
Owner

btzy commented Apr 20, 2023

On all four backends, these three APIs actually call a single platform native API. NFDe is essentially calling the same code, but setting a flag to determine whether to select files or folders, and whether to select single vs multiple items. Since all backends only actually use a single API with options, NFDe should probably do the same too. As a bonus, we will also support the ability to select multiple folders.

Note that on MacOS, the native API seems to be even more flexible - you can choose to allow the selection of both files and folders.

Or maybe it shouldn't be merged for single vs multiple due to the differing return type, but at least we can merge the files vs folders part.

@btzy btzy added this to the v1.1 new API milestone Apr 20, 2023
@btzy
Copy link
Owner Author

btzy commented May 12, 2024

Not intending to do this, since the way to retrieve multiple files different from retrieving a single file. PickFolderMultiple will be separately introduced.

@btzy btzy closed this as completed May 12, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant