Allow list section defaults to be filtered, account for container class #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the defaults for child menus to be altered before output.
WordPress provides a `sub-menu` class by default with menus. Allowing this to be modified in BU Navigation can help when converting an existing menu with existing styles and interactions.
I *think* BU Navigation is using WP core styles in newer stuff.
jeremyfelt
added a commit
to washingtonstateuniversity/WSUWP-Build-Plugins-Public
that referenced
this pull request
Jul 27, 2017
We need this in ASAP for Murrow. See bu-ist/bu-navigation#34 for upstream resolution.
desrosj
approved these changes
Aug 1, 2017
|
Also to note, I reached out to Code Climate support. Open source repositories are free (which would allow us to evaluate incoming code from the community), but because this repo was added under the organization's umbrella it is saying @jeremyfelt needs to be added as a paid user. Seeing if there is a way to separate this repo. |
|
Clearing out my open PRs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're converting styles and JavaScript that we've previously used with a standard WP nav menu and
sub-menuis used by WordPress for child<ul>elements by default. This change makes it possible to filter the container class for sections as it is output.Thanks for BU Navigation, we love it at WSU. 🍻