New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace widget #85

Merged

jdub233 merged 3 commits into develop from namespace-widget

Feb 3, 2021

Contributor

jdub233 commented Feb 2, 2021

Moves the widget code to a new file with the new core namespace, while leaving the original class declaration in place for compatibility. The original class now just extends the new class with no modifications.
Also fixes some missing control structures in the exclude filter

jdub233 added 3 commits

February 2, 2021 15:08


          fix critical missing control structures

ec8d1b5


          🎨 spacing fixes

6ab66b9


          ♻️ move the widget class to namespace

8a45ae4

and leave behind a stub class that just inherits everything from the new namespaced class

rfera213 approved these changes

View reviewed changes

rfera213 left a comment

Just moving some functions into a namespace - Looks good to me!

jdub233 merged commit 5a01c5b into develop

jdub233 deleted the namespace-widget branch

February 3, 2021 22:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment