Headings after visually hidden page titles should not get margin-top #174
Assignees
Comments
ashleykolodziej
added a commit
that referenced
this issue
Dec 3, 2018
ashleykolodziej
added a commit
that referenced
this issue
Jan 8, 2019
* Replaces `grunt-contrib-sass` with `grunt-sass` (uses `node-sass` under the hood) * Uses full path to node modules depenencies, rather than depending on loadPath * Small bugfixes when trying to compile sass locally in this repo, due to incorrect paths. * Add a new partial, `burf-tools`, for minimal uses of Foundation * Adds mega menu support for child themes by default. * Fixes an issue preventing the icons mixin from being used inside media queries * Icon placeholders and classes are now generated from the $icons-responsive map * Adds the ability to change the before/after placement of icons globally across the theme * Fixes skip link issues [#173](#173) * Fixes a spacing issue with hidden page titles [#174](#174) * Adds variable to control gallery margin [#174](#174) * Fixes [#103](#103) * Fixes [#97](#97) with new `$padding-banner` and `$padding-banner-window-width` variables * Fixes [#84](#84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By default, heading tags get a margin-top unless they are the first child. But if the page title is visually hidden, the margin-top stays. We should write a rule to target this scenario and remove the margin-top.
The text was updated successfully, but these errors were encountered: