Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: widget-navigation.scss using different variable #235

Closed
crystalms opened this issue May 7, 2020 · 0 comments · Fixed by #237 or #239
Closed

Bug: widget-navigation.scss using different variable #235

crystalms opened this issue May 7, 2020 · 0 comments · Fixed by #237 or #239

Comments

@crystalms
Copy link

crystalms commented May 7, 2020

It appears that the _widget-navigation.scss is using the $border-widget-list variable instead of the $border-widget-contentnav (which is declared in the theme's _widget-navigation.scss), so when I tried updating the $border-widget-contentnav in my theme, it had no effect.

I'm not sure whether or not this is intentional or a bug. According to the documentation in the scss file, it says: Controls the style of border used on the content navigation list. So if this is the intended functionality we might want to clarify that there to avoid any confusion.

ashleykolodziej added a commit that referenced this issue Jan 5, 2021
* Fixes #235
* Removes BU Default Icons
* Adds FontAwesome Free and FontAwesome Brands
* Adds a new variable, `$font-weight-icon`, to control which set of FontAwesome icons loads
* `$widget-title-link-after` has been deprecated in favor of `$widget-title-link-icon`
* Removes pre-IE9 support for icons, per FontAwesome standard.
* Moves to Github Packages for releases.
* Renames `tools-cgb` to `tools-webpack`.
* Reorganizes foundation into `burf-base`, `burf-theme`, `burf-tools`, and a new `burf-customizations`
* Migrates the following partials from `burf-theme` to `burf-customizations`:
    - `content/collapsibles`;
    - `content/courses`;
    - `profiles/profile-format-default`;
    - `profiles/profile-format-basic`;
    - `profiles/profile-format-advanced`;
    - `profiles/profile-format-mini`;
    - `content/slideshows`;
    - `calendar/widget-calendar`;
    - `calendar/calendar-picker`;
    - `layout/branding`;
    - `calendar/calendar-archive`;
    - `profiles/profile-archive`;
    - `calendar/calendar-single`;
    - `profiles/profile-single`;
    - `bulp/bulp-base`;
* Migrates the following partials from `burf-base` to `burf-customizations`:
    - `fonts`;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants