Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Material You and dyanmic colors #89

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

ebraminio
Copy link
Contributor

@ebraminio ebraminio commented Nov 14, 2021

Upgrade to Material You and dynamic colors, probably can't be applied just right now as material library is beta01 and isn't stable, the following screencast is taken from Android Sv2 image of the emulator,

Screen.Recording.2021-11-15.at.12.45.10.AM.mov

@bubelov bubelov merged commit 69c40fb into bubelov:master Nov 15, 2021
@bubelov
Copy link
Owner

bubelov commented Nov 15, 2021

@ebraminio it mostly works fine on my phone, two minor issues:

  1. Top app bar changes color while scrolling, it looks like it's jumping between two colors
  2. Bottom bar colors are slightly different in light mode. I'm using Android 11

Here is the screenshot showing those issues:

index

@bubelov
Copy link
Owner

bubelov commented Nov 15, 2021

@ebraminio I played with it a bit more and decided to limit it to Android 12 and later. There aren't a lot of people who uses Android 12 so we can experiment and hear some feedback. People who use older Android will have the old theme for now. I'll file an issue for tracking migration to Material 3

@ebraminio
Copy link
Contributor Author

I played with it a bit more and decided to limit it to Android 12 and later. There aren't a lot of people who uses Android 12 so we can experiment and hear some feedback. People who use older Android will have the old theme for now. I'll file an issue for tracking migration to Material 3

Sorry for not spotting the issues, limiting to Android 12 feels like a good short term plan, thanks :)

@ebraminio ebraminio deleted the dynamic-theme branch November 15, 2021 13:29
@ebraminio
Copy link
Contributor Author

have put some time on this and still clueless how the scroll is making effect there and how that only happens in Material 3 :/

@bubelov
Copy link
Owner

bubelov commented Nov 16, 2021

@ebraminio might be an issue with beta, or maybe it supposed to change color slightly to indicate that the content is up-scrollable, but it's just a speculation. I'll try to update the deps related to list widget, etc. If this won't help, it probably makes sense to wait for Material 3 to go out of beta before rolling it up to older versions of Android. By the way, I moved all v31 related styles to a single file, so it's easier to play with the new theme without affecting the lower targets:

https://github.com/bubelov/news/blob/master/app/src/main/res/values-v31/styles.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants