New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect aliased variable names when desctructuring #94

Merged

adrianheine merged 1 commit into bublejs:master from nathancahill:destructureFuncNameParam

Jan 10, 2018

Collaborator

nathancahill commented Jan 9, 2018

When declarator.init is an aliased variable, the alias wasn't looked at when choosing the name for the desctructuring.


          respect aliased variable names when desctructuring - fixes bublejs#86

c7265b9

nathancahill mentioned this pull request

Transpiling loop bodies to functions emits wrong code with aliased variables #80

Open

adrianheine merged commit d914011 into bublejs:master

Member

adrianheine commented Jan 10, 2018

Thanks. This is pretty arcane, but I couldn't find another bug like this.

pirxpilot mentioned this pull request

incorrect aliased/shadowed variable name when destructuring in the loop #142

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment