Fix positioning of continue label on iPhone X #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the iPhone X simulator, the continue label is clipped by the "notch" when displayed at the top and overlaps the home bar at the bottom.
Here is the unmodified example app running on the iPhone X simulator:
This PR adds support for UIKit's new safe area insets. If built with the iOS 11 SDK, and running on a version of iOS that supports
UIView safeAreaInsets, the code will adjust the position of the continue label to avoid these collisions.Here's the example app with this fix:
Also, I noticed that the two copies of
MPCoachMarks.m-Example/Example/MPCoachMarks/MPCoachMarks.mandMPCoachMarks/MPCoachMarks.mare slightly different. I've made this fix in both files.