Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plugins updater and improve local cheats + patches updater #98

Merged
merged 24 commits into from Jun 23, 2023

Conversation

illusion0001
Copy link
Contributor

@illusion0001 illusion0001 commented Jun 16, 2023

  • Now tries to find matching names in /mnt/usb0-7/ (8 possible mounted usb partitions) and /data/GoldHEN/ and the following folders:

    • (root)

    • cheats

    • patches

    • plugins

    • Valid start with filenames:

    • Cheats

      • cheats
      • GoldHEN_Cheat_Repository
    • Patches

      • patches
      • patch1
    • Plugins

      • GoldPlugins
      • plugins
  • Changed backup paths from /mnt/usb0/ and /data/GoldHEN/ to /mnt/usb0/backups/(name) /data/GoldHEN/backup/name/

image

Fixes #31

source/cheats.c Outdated Show resolved Hide resolved
@illusion0001 illusion0001 force-pushed the plugins-updater branch 13 times, most recently from bc3768b to 4d573ef Compare June 18, 2023 04:00
@illusion0001
Copy link
Contributor Author

Added plugins file permission fix in settings menu.

This reverts commit 971244f.

Update cheats.c
@bucanero
Copy link
Owner

Checking if path is writeable seems to be better.

1.mp4

oh perfect, this is better! 👍 My original idea was to show only the available USB drives (but used some code from Apollo without any testing)

@bucanero bucanero force-pushed the plugins-updater branch 2 times, most recently from accbe3a to 2580d34 Compare June 22, 2023 13:54
Update zip_util.c

upd

clean
Comment on lines +537 to +539
snprintf(local_path, sizeof(local_path), "%s%s", item->path, search[0]);
if (dir_exists(local_path) != SUCCESS)
continue;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@illusion0001 I added a check here to speed up the process. (no need to call find_zip(...) if the dir doesn't exists)

@bucanero
Copy link
Owner

I think this is ready to merge. Feel free to test and check anything, let me know how it goes 👍

@illusion0001
Copy link
Contributor Author

I will test and report if everything is working correctly

`cheats/` `/patches` and `/plugins`
@illusion0001
Copy link
Contributor Author

seems good. i added case if user made backup of /cheats folder

@illusion0001

This comment was marked as outdated.

@illusion0001

This comment was marked as outdated.

@illusion0001
Copy link
Contributor Author

@bucanero good to merge

@bucanero bucanero merged commit c4c1f2b into bucanero:main Jun 23, 2023
1 check passed
@illusion0001 illusion0001 deleted the plugins-updater branch June 24, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we use a shortter when importing usb cheats
2 participants