Skip to content
This repository has been archived by the owner on Nov 15, 2018. It is now read-only.

Fill Hawkular-APM with Lightbright traces #7

Closed
1 of 2 tasks
lance opened this issue Jun 1, 2016 · 9 comments
Closed
1 of 2 tasks

Fill Hawkular-APM with Lightbright traces #7

lance opened this issue Jun 1, 2016 · 9 comments
Assignees
Milestone

Comments

@lance
Copy link
Member

lance commented Jun 1, 2016

  • Finish the data mapping between lightbright and hawkular-apm json.
  • Avoid trace data polution on hawkular-apm-server from roi module.
@helio-frota helio-frota changed the title Research Hawkular client needs Fill Hawkular-APM with Lightbright traces Aug 23, 2016
@helio-frota
Copy link
Member

More information:
#11

@lance
Copy link
Member Author

lance commented Sep 28, 2016

@helio-frota
Copy link
Member

Now is more easy to identify any difference from roi trace data
bucharest-gold/hawkular-apm-client#5 (comment)

Instead send to hawkular-server:
https://github.com/bucharest-gold/hawkular-apm-client/blob/master/index.js#L70

We send to console.log();

Because the FakeApp is calling publishTraces here:
https://github.com/bucharest-gold/hawkular-apm-client/blob/master/test/app-fixture.js#L24

Then we can see if has any difference with roi usage.

@helio-frota
Copy link
Member

helio-frota commented Oct 6, 2016

@helio-frota
Copy link
Member

#7 (comment)
We don't need to worry about this anymore, all the tests are showing the same thing please see the gist ^^

@helio-frota
Copy link
Member

@helio-frota
Copy link
Member

When accessing the example App multiple times, then new wrapers/handlers arise.

I have no idea if this is correct/expected:
https://gist.github.com/helio-frota/bf11e2409fa908c7eda2cb0dd37522f3

Every time the text appears on the gist is one access to example app url:
"Traces added to hawkular-apm-server."

@helio-frota
Copy link
Member

a
b

@lance
Copy link
Member Author

lance commented Oct 27, 2016

After discussing this with @balunasj we've decided to close this issue, and track progress towards this in bucharest-gold/lightbright since the implementation of any given data format would probably be most efficiently accomplished as a lightbright filter. See: bucharest-gold/lightbright#11.

@lance lance closed this as completed Oct 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants