Skip to content
This repository has been archived by the owner on Nov 15, 2018. It is now read-only.

limit "engines" to <8 #16

Merged
merged 1 commit into from
Oct 18, 2017
Merged

limit "engines" to <8 #16

merged 1 commit into from
Oct 18, 2017

Conversation

refack
Copy link
Contributor

@refack refack commented Sep 23, 2017

With the introduction of async-hooks in v8.x, there should be a way to do this without process.binding('async_wrap');

With the introduction of `async-hooks` in v8.x, there should be a way to do this without `process.binding('async_wrap');`
@ghost ghost added the in progress label Sep 23, 2017
@coveralls
Copy link

coveralls commented Sep 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling f0f5b01 on refack:patch-1 into 7ea43ea on bucharest-gold:master.

@lance
Copy link
Member

lance commented Oct 18, 2017

@refack thanks for the contribution - and apologies for the latency. This is a back-burner project for me. 👍

@lance lance merged commit 9a75f3f into bucharest-gold:master Oct 18, 2017
@ghost ghost removed the in progress label Oct 18, 2017
@lance lance self-assigned this Oct 18, 2017
@refack refack deleted the patch-1 branch October 19, 2017 19:13
@refack
Copy link
Contributor Author

refack commented Oct 19, 2017

Just trying to limit the use of process.binding('async_wrap'); in the wild.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants