fix a bug with unused dependencies report.

Addresses #19
bucharest-gold · Sep 16, 2016 · af26a66 · af26a66
1 parent c2b21a8
commit af26a66
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 7 deletions.
diff --git a/lib/reporter.js b/lib/reporter.js
@@ -5,7 +5,8 @@ const fs = require('fs');
 
 module.exports = {
   report: report,
-  fileReport: fileReport
+  fileReport: fileReport,
+  unused: unused
 };
 
 function flatResult (result) {
@@ -71,23 +72,23 @@ function strFileLines (grouped) {
 }
 
 function unused (declarations, dependencies) {
-  const unused = [];
+  const unused = new Set();
   if (declarations.length) {
     dependencies.forEach(dep => {
       declarations.forEach(d => {
         if (d) {
-          if (!d.includes(dep)) {
-            unused.push(dep);
+          if (!d.toUpperCase().includes(dep.toUpperCase())) {
+            unused.add(dep);
           }
         }
       });
     });
   } else {
     dependencies.forEach(dep => {
-      unused.push(dep);
+      unused.add(dep);
     });
   }
-  return unused;
+  return Array.from(unused);
 }
 
 function jsonReporter (result, dependencies) {

diff --git a/test/fixtures/package.json b/test/fixtures/package.json
@@ -7,7 +7,8 @@
     "test": "n/a"
   },
   "dependencies": {
-    "roi": "^0.2.'"
+    "roi": "^0.2.'",
+    "fidelity": "0.1.2"
   },
   "license": "Apache-2.0",
   "devDependencies": {

diff --git a/test/szero-test.js b/test/szero-test.js
@@ -90,3 +90,13 @@ test('Should report to file.', t => {
   }
   t.end();
 });
+
+test('Should show unused dependencies from report.', t => {
+  const packageJsonLines = reader.read(path.join(__dirname, '/fixtures/package.json'));
+  const dependencies = searcher.searchDependencies(packageJsonLines);
+  const javascriptLines = reader.read(path.join(__dirname, '/fixtures/foo/x.js'));
+  const declarations = searcher.searchDeclarations(javascriptLines, dependencies);
+  const unused = reporter.unused(declarations, dependencies);
+  t.equal(unused.toString(), 'fidelity');
+  t.end();
+});