Skip to content
This repository has been archived by the owner on Nov 15, 2018. It is now read-only.

Run function refactored #103

Merged
merged 3 commits into from May 12, 2017
Merged

Conversation

tiagofabre
Copy link
Contributor

@tiagofabre tiagofabre commented May 12, 2017

Run function now makes less things.

Also getTextFromRequire is being reutilized to avoid this

This pull request is trying to solve #59

  • Testes - total: 61 - passing: 61
  • The output is the same before and after the modifications
  • ESlint

@coveralls
Copy link

coveralls commented May 12, 2017

Coverage Status

Coverage increased (+0.6%) to 90.0% when pulling b1eed1d on tiagofabre:refactoring into f03e149 on bucharest-gold:master.

@helio-frota
Copy link
Member

@tiagofabre it is looking great, but can you please remove the default parameter from
function run (directory, options = {}) {
since node 4x does not support this.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 90.031% when pulling cdac961 on tiagofabre:refactoring into f03e149 on bucharest-gold:master.

1 similar comment
@coveralls
Copy link

coveralls commented May 12, 2017

Coverage Status

Coverage increased (+0.7%) to 90.031% when pulling cdac961 on tiagofabre:refactoring into f03e149 on bucharest-gold:master.

@helio-frota helio-frota merged commit c5808ec into bucharest-gold:master May 12, 2017
@ghost ghost removed the in progress label May 12, 2017
@helio-frota
Copy link
Member

@tiagofabre thanks !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants