Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecuritiesTable ChangeOnPrevious #1293

Closed
wants to merge 1 commit into from
Closed

SecuritiesTable ChangeOnPrevious #1293

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 30, 2019

Change calculation of col. "ChangeOnPrevious" from current date logic where data provided by LatestSecurityPrice, as this record set is only updated if quotes are online updated, manual maintained quote prices bypassing this logic.

This change is use now the closest fitting date to current date and the previous date.

https://forum.portfolio-performance.info/t/kursaenderung-zum-vortag-ist-falsch/5189/22

buchen added a commit that referenced this pull request Dec 1, 2019
- removed obsolete usage of Yahoo previous close
- refactored lookup of previous close into the Security class
- added tooltip that shows the two quotes that are used to calculate the delta

Issue: #1293
Issue: https://forum.portfolio-performance.info/t/kursaenderung-zum-vortag-ist-falsch/5189/22
@buchen
Copy link
Member

buchen commented Dec 1, 2019

rebased and merged.

Ich habe den "lookup" von aktuellen und "previous" in eine Methode von Security gepackt da es sich da einfacher testen lässt.

@buchen buchen closed this Dec 1, 2019
cmaoling pushed a commit to cmaoling/portfolio that referenced this pull request Feb 18, 2020
- removed obsolete usage of Yahoo previous close
- refactored lookup of previous close into the Security class
- added tooltip that shows the two quotes that are used to calculate the delta

Issue: portfolio-performance#1293
Issue: https://forum.portfolio-performance.info/t/kursaenderung-zum-vortag-ist-falsch/5189/22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant