Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-2031] Fix a typo in the translation files #562

Closed
ainigma32 opened this issue Sep 5, 2022 · 2 comments
Closed

[BP-2031] Fix a typo in the translation files #562

ainigma32 opened this issue Sep 5, 2022 · 2 comments
Assignees
Labels
Status: Waiting for release This issue has been solved, but is not released yet.

Comments

@ainigma32
Copy link

Hi all,

There is a typo in the translation files which results in untranslated content.
In the translation files there is this string:
"Your order has been placed succesfully."

The file that should be using this string is:
Controller/Redirect/Process.php

But there is a slight difference:

$this->addSuccessMessage(__('Your order has been placed successfully.'));

Note the double s at the end of success.

AFAIK the correct spelling is successfully which would mean the translation files need to be corrected.

Found this in version 1.42.0 of this module.

@Buckaroo-Rene Buckaroo-Rene added the Status: Backlog This is currently on our backlog and not scheduled yet. label Sep 6, 2022
@Buckaroo-Rene Buckaroo-Rene self-assigned this Sep 6, 2022
@Buckaroo-Rene
Copy link
Contributor

Hi @ainigma32 ,

Thank you for informing us about this issue.
I have created a ticket for it and this will be picked up in one of our upcoming sprints.

Ticket: BP-2031

@Buckaroo-Rene Buckaroo-Rene changed the title Typo in translation files [BP-2031] Fix a typo in the translation files Sep 6, 2022
@Buckaroo-Rens Buckaroo-Rens added Status: Waiting for release This issue has been solved, but is not released yet. and removed Status: Backlog This is currently on our backlog and not scheduled yet. labels Sep 30, 2022
@Buckaroo-Rens
Copy link
Collaborator

Released in 1.43.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for release This issue has been solved, but is not released yet.
Projects
None yet
Development

No branches or pull requests

3 participants