#274, #275: remove unnecessary code

bucket4j · Jul 13, 2022 · 06189b5 · 06189b5
1 parent c7f512a
commit 06189b5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 38 deletions.
diff --git a/bucket4j-redis/src/main/java/io/github/bucket4j/redis/jedis/cas/JedisBasedProxyManager.java b/bucket4j-redis/src/main/java/io/github/bucket4j/redis/jedis/cas/JedisBasedProxyManager.java
@@ -80,17 +80,7 @@ public boolean compareAndSwap(byte[] originalData, byte[] newData, RemoteBucketS
 
     @Override
     protected AsyncCompareAndSwapOperation beginAsyncCompareAndSwapOperation(byte[] key) {
-        return new AsyncCompareAndSwapOperation() {
-            @Override
-            public CompletableFuture<Optional<byte[]>> getStateData() {
-                return withResource(jedis -> CompletableFuture.supplyAsync(() -> Optional.ofNullable(jedis.get(key))));
-            }
-
-            @Override
-            public CompletableFuture<Boolean> compareAndSwap(byte[] originalData, byte[] newData, RemoteBucketState newState) {
-                return CompletableFuture.supplyAsync(() -> JedisBasedProxyManager.this.compareAndSwap(key, originalData, newData, newState));
-            }
-        };
+        throw new UnsupportedOperationException();
     }
 
     @Override

diff --git a/...s/src/main/java/io/github/bucket4j/redis/spring/cas/SpringDataRedisBasedProxyManager.java b/...s/src/main/java/io/github/bucket4j/redis/spring/cas/SpringDataRedisBasedProxyManager.java
@@ -39,31 +39,18 @@ public class SpringDataRedisBasedProxyManager extends AbstractCompareAndSwapBase
 
     private final RedisCommands commands;
     private final long keepAfterRefillDurationMillis;
-    private final boolean isAsyncModeSupported;
 
     /**
      *
      * @param redisCommands
      * @param clientSideConfig
-     * @param keepAfterRefillDuration
-     * @param isAsyncModeSupported specifies how long bucket should be held in the cache after all consumed tokens have been refilled.
+     * @param keepAfterRefillDuration specifies how long bucket should be held in the cache after all consumed tokens have been refilled.
      */
-    public SpringDataRedisBasedProxyManager(RedisCommands redisCommands, ClientSideConfig clientSideConfig, Duration keepAfterRefillDuration, boolean isAsyncModeSupported) {
+    public SpringDataRedisBasedProxyManager(RedisCommands redisCommands, ClientSideConfig clientSideConfig, Duration keepAfterRefillDuration) {
         super(clientSideConfig);
         Objects.requireNonNull(redisCommands);
         this.commands = redisCommands;
         this.keepAfterRefillDurationMillis = keepAfterRefillDuration.toMillis();
-        this.isAsyncModeSupported = isAsyncModeSupported;
-    }
-
-    /**
-     *
-     * @param redisCommands
-     * @param clientSideConfig
-     * @param keepAfterRefillDuration specifies how long bucket should be held in the cache after all consumed tokens have been refilled.
-     */
-    public SpringDataRedisBasedProxyManager(RedisCommands redisCommands, ClientSideConfig clientSideConfig, Duration keepAfterRefillDuration) {
-        this(redisCommands, clientSideConfig, keepAfterRefillDuration, true);
     }
 
     /**
@@ -91,17 +78,7 @@ public boolean compareAndSwap(byte[] originalData, byte[] newData, RemoteBucketS
 
     @Override
     protected AsyncCompareAndSwapOperation beginAsyncCompareAndSwapOperation(byte[] key) {
-        return new AsyncCompareAndSwapOperation() {
-            @Override
-            public CompletableFuture<Optional<byte[]>> getStateData() {
-                return CompletableFuture.supplyAsync(() -> Optional.ofNullable(commands.get(key)));
-            }
-
-            @Override
-            public CompletableFuture<Boolean> compareAndSwap(byte[] originalData, byte[] newData, RemoteBucketState newState) {
-                return CompletableFuture.supplyAsync(() -> SpringDataRedisBasedProxyManager.this.compareAndSwap(key, originalData, newData, newState));
-            }
-        };
+        throw new UnsupportedOperationException();
     }
 
     @Override
@@ -116,7 +93,7 @@ protected CompletableFuture<Void> removeAsync(byte[] key) {
 
     @Override
     public boolean isAsyncModeSupported() {
-        return isAsyncModeSupported;
+        return false;
     }
 
     private final byte[] scriptSetNx = "return redis.call('set', KEYS[1], ARGV[1], 'nx', 'px', ARGV[2])".getBytes(StandardCharsets.UTF_8);