Improve retries and add more guarding code #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roncohen
reviewed
Nov 2, 2023
roncohen
reviewed
Nov 7, 2023
rrpff
approved these changes
Nov 7, 2023
matus-vacula
reviewed
Nov 8, 2023
Co-authored-by: Matus Vacula <vacula.matus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-arranges some code to move "get a new token" retry from inside the "event listener's" loop and join it to the main retry loop.
This is to avoid any hypothetical situation when Ably misbehaves about our tokens' validity and we constantly try to obtain a new token and connect to Ably, thus entering an unwanted loop.
To improve things, I have also made sure that when we connect successfully, we reset the retry count to its default value to not exhaust retries on normal reconnects due to token expiration.