-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache Ably auth-cookie #88
Cache Ably auth-cookie #88
Conversation
pavkam
commented
Dec 12, 2023
•
edited
edited
- Cache the cookie locally (for its validity time),
- Also, added cookie settings to avoid Firefox complaints: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#samesitesamesite-value
how about also skipping calls to our ingest if we just did those calls? (non-spa apps) |
This one avoids one call to Ingest and one to Ably. One more call remains - is the |
Done, this should avoid the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change the getAuthToken
interface to never throw and instead just return undefined
in the case of an invalid cookie payload
Co-authored-by: Peter Müller <peter@bucket.co>