Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add gen_proto_check command #413

Merged
merged 3 commits into from
Jun 15, 2023
Merged

ci: add gen_proto_check command #413

merged 3 commits into from
Jun 15, 2023

Conversation

ono-max
Copy link
Contributor

@ono-max ono-max commented Jun 14, 2023 •
edited

This PR cherry-picks #412.

As #398 (comment), we need to validate generated files from gen_proto

@masaaania
Copy link
Contributor

We should add the path proto/** to on.pull_request.paths.

https://github.com/bucketeer-io/bucketeer/pull/413/files#diff-caa0cb0d2019539d16ca4a7b4b7f53f15157b75b47d060186bf5c06b7c7f2b61L7-L9

@ono-max ono-max mentioned this pull request Jun 14, 2023
Closed
masaaania
masaaania approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@masaaania masaaania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ono-max ono-max changed the title chore: add gen_proto_check command ci: add gen_proto_check command Jun 15, 2023
cre8ivejp
cre8ivejp approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@cre8ivejp cre8ivejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ono-max ono-max merged commit b2dd4fe into main Jun 15, 2023
15 checks passed
@ono-max ono-max deleted the patch-45 branch June 15, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cre8ivejp cre8ivejp cre8ivejp approved these changes

@masaaania masaaania masaaania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ono-max @masaaania @cre8ivejp