New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new auth architecture #924
Open
Ubisoft-potato
wants to merge
10
commits into
main
Choose a base branch
from
feature-google-authentication
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubisoft-potato
force-pushed
the
feature-google-authentication
branch
2 times, most recently
from
April 23, 2024 07:21
27f4cb7
to
c976cfa
Compare
Ubisoft-potato
force-pushed
the
feature-google-authentication
branch
from
April 24, 2024 04:19
8702095
to
2ff8c25
Compare
Here is a auth archtechture change illustration: The Admin Console need to make some changes to support the new auth archtechture:
|
Ubisoft-potato
force-pushed
the
feature-google-authentication
branch
from
May 2, 2024 04:03
8c9c09a
to
a789e4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #919
This PR implements a new authentication architecture in the
auth
module. This architecture will support the addition of new authentication methods, such as Github, SSO, etc.Key changes
google
is used to configure for Google Authentication.dex
anymore.auth
service and token verifierauth_type
field inauth
proto file to support multi authentication methodauth
serviceMinor changes
ioutil.ReadFile
toos.ReadFile
, becauseioutil
was deprecated since go1.16New authentication workflow
GetAuthCodeURL
to get the Login URLredirect_url
withcode
ExchangeToken
withcode
to get Bucketeer TokenRefreshTokenRequest
withrefresh_token
to refresh Bucketeer TokenCheck the illustration.
This pull request primarily introduces changes to improve the OAuth configuration in the Bucketeer backend and batch services. The key changes involve the addition of a new 'provider' field in the service token generation command, removal of the issuer-cert-secret, and restructuring of the OAuth configuration.
Here's a breakdown of the most important changes:
Service Token Generation:
Makefile
: Added a new 'provider' option in thegenerate-service-token
command.hack/generate-service-token/command.go
: Introduced a new 'provider' field in the command structure and updated the command registration and execution functions to include this new field. [1] [2] [3]OAuth Configuration:
manifests/bucketeer/charts/backend/templates/deployment.yaml
: Removed the issuer-cert-secret and added a new oauth-config ConfigMap. Also, restructured the environment variables related to OAuth configuration. [1] [2] [3] [4]manifests/bucketeer/charts/backend/templates/oauth-configmap.yaml
: Created a new ConfigMap for OAuth configuration.manifests/bucketeer/charts/backend/values.dev.yaml
,manifests/bucketeer/charts/backend/values.yaml
: Restructured the OAuth configuration in the values files. [1] [2]Batch Service OAuth Configuration:
manifests/bucketeer/charts/batch/templates/deployment.yaml
: Added a new oauth-config ConfigMap and updated the environment variables and volume mounts related to OAuth configuration. [1] [2] [3]manifests/bucketeer/charts/batch/templates/oauth-configmap.yaml
: Created a new ConfigMap for OAuth configuration in the batch service.manifests/bucketeer/charts/batch/values.dev.yaml
,manifests/bucketeer/charts/batch/values.yaml
: Updated the OAuth configuration in the values files for the batch service. [1] [2]