Tweaks for API compatibility and adding From address #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 4, 2011 15:44
sms_mediaburst_admin_form - New long SMS and From address configuration options, that can optionally be used in the send. sms_mediaburst_admin_form_validate - validates From option to make sure it will work with the SMS API. sms_mediaburst_send - Strip out non-numeric characters from mobile numbers. - Only prefix country code if mobile number starts with 0 sms_mediaburst_command - Use rawurlencode rather than drupal_urlencode to prevent double encoding. - URL Encode username & password - Set concat & from parameters on API call - Send as UCS-2 if non-GSM characters are used rather than using Unicode. sms_mediaburst_is_gsm - Check if all characters used are in the GSM character set
|
Are you able to provide an SMS account for testing these changes? |
|
If you could let me know your email address I'll get you a test account setup with 50 free SMS. If you'd prefer to set it up off Github just drop an email to hello@mediaburst.co.uk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've made a few tweaks to your SMS module to improve compatibility with the Mediaburst API such as swapping Unicode to UCS-2, I've also added support for long (greater than 160 character) messages.
I don't have a fully functioning Drupal install and I've never used it so I haven't been able to fully test the features within Drupal.
Martin.