Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bundleSfx: true" still returns config.js #8

Open
techniq opened this issue Nov 9, 2015 · 5 comments
Open

"bundleSfx: true" still returns config.js #8

techniq opened this issue Nov 9, 2015 · 5 comments
Labels

Comments

@techniq
Copy link

techniq commented Nov 9, 2015

Currently I'm get "System is not defined" when performing a bundleSfx: true because the config.js is in the pipeline. Unless I'm mistaken, should this not be the case.

Semi-related, it seems like it would be useful to have system.js bundled for buildleSfx: false build (as long as the system.js, config.js, some-bundle.js order was maintained?

@buddhike buddhike added the bug label Nov 15, 2015
@OliverJAsh
Copy link

If SFX, don't output the config, as it isn't necessary?

@techniq
Copy link
Author

techniq commented Nov 23, 2015

Correct, as neither is system.js. It's all self contained.

On Sun, Nov 22, 2015, 5:21 PM Oliver Joseph Ash notifications@github.com
wrote:

If SFX, don't output the config, as it isn't necessary?


Reply to this email directly or view it on GitHub
#8 (comment)
.

@buddhike
Copy link
Owner

@techniq Thanks for getting to the bottom of this. I was wondering why this happens to some users.
Bunding system.js for non sfx would be a handy feature (I will no longer have to copy jspm_packages dir to build output then ;-))

BTW: What would happen if you generate many non-fx bundles? Each of them should not have systemjs and configjs right?

@buddhike
Copy link
Owner

buddhike commented Feb 9, 2016

I bumped into this issue recently. This is what I discovered.

  • System not defined error was because my sfx bundle wasn't produced correctly. This was because I has sfx option specified at the wrong level so it was producing a true sfx bundle.
  • config.js is produced in the output although it's not necessary. However having config.js does not cause System is not define error.

Will leave this issue open until we get rid of config.js from the output.

@dwhu
Copy link

dwhu commented Aug 20, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants