Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Bypass WordPress Show Avatars settings and set always true #1256

Merged
merged 8 commits into from Sep 22, 2020

Conversation

chetansatasiya
Copy link
Collaborator

All Submissions:

Changes proposed in this Pull Request:

Fixes #ISSUE_NUMBER .

How to test the changes in this Pull Request:

Proof Screenshots or Video

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@chetansatasiya chetansatasiya self-assigned this Jul 24, 2020
@chetansatasiya chetansatasiya added bug Bugs or issues identified in this product. php priority-high Important, but no one will go out of business. labels Jul 24, 2020
@chetansatasiya chetansatasiya added this to In Progress in BuddyBoss Platform via automation Jul 24, 2020
@chetansatasiya chetansatasiya moved this from In Progress to Needs Review in BuddyBoss Platform Jul 24, 2020
@chetansatasiya chetansatasiya added status-needs-review PR that needs review. status-needs-qa Issue or PR that needs testing labels Jul 24, 2020
src/bp-core/bp-core-filters.php Outdated Show resolved Hide resolved
Copy link
Contributor

@mehulkaklotar mehulkaklotar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chetansatasiya we should not always send true for WP's comment here https://prnt.sc/uln8u6

It will break the WP's settings and customer will come for support from WP that setting doesn't save. We need different approach here. We can just define true BP_SHOW_AVATARS always and based on settings saved in WP, we should hide this option https://prnt.sc/ulnoo1 and the function related to it will always give wp's selected option.

Merge dev here also.

Copy link
Contributor

@mehulkaklotar mehulkaklotar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chetansatasiya perfect! 🚀

Tested!

BuddyBoss Platform automation moved this from Needs Review to Approved by Reviewer(s) Sep 22, 2020
@mehulkaklotar mehulkaklotar merged commit 6fdc301 into dev Sep 22, 2020
BuddyBoss Platform automation moved this from Approved by Reviewer(s) to Merged for Release (dev branch) Sep 22, 2020
@mehulkaklotar mehulkaklotar deleted the fix/show-avatars-wp-fix branch September 22, 2020 09:37
@mehulkaklotar mehulkaklotar added status: approved and removed status-needs-review PR that needs review. status-needs-qa Issue or PR that needs testing labels Sep 22, 2020
@sourabhmatolia sourabhmatolia moved this from Merged for Release (dev branch) to Released in BuddyBoss Platform Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or issues identified in this product. priority-high Important, but no one will go out of business.
Projects
BuddyBoss Platform
  
Released
Development

Successfully merging this pull request may close these issues.

None yet

2 participants