New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Bypass WordPress Show Avatars settings and set always true #1256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chetansatasiya we should not always send true for WP's comment here https://prnt.sc/uln8u6
It will break the WP's settings and customer will come for support from WP that setting doesn't save. We need different approach here. We can just define true BP_SHOW_AVATARS
always and based on settings saved in WP, we should hide this option https://prnt.sc/ulnoo1 and the function related to it will always give wp's selected option.
Merge dev here also.
…x/show-avatars-wp-fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chetansatasiya perfect! 🚀
Tested!
All Submissions:
Changes proposed in this Pull Request:
Fixes #ISSUE_NUMBER .
How to test the changes in this Pull Request:
Proof Screenshots or Video
Other information:
Changelog entry