Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure generic functions are available outside of a REST request #148

Merged
merged 1 commit into from Feb 6, 2019

Conversation

imath
Copy link
Member

@imath imath commented Feb 6, 2019

When building endpoint for a JavaScript use, we need to be able to use:

  • bp_rest_namespace()
  • bp_rest_version()

Another option could be to simply move them into the bp-rest.php file.

When building endpoint for a JavaScript use, we need to be able to use:
- `bp_rest_namespace()`
- `bp_rest_version()`

Another option could be to simply move them into the `bp-rest.php` file.
Copy link
Member

@renatonascalves renatonascalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I presumed that would be necessary sooner or later. :)

@renatonascalves renatonascalves merged commit 608eb50 into buddypress:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants