Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XProfile field: test string with apostrophes is handled correctly in a field update #497

Merged
merged 4 commits into from
Apr 12, 2024
Merged

XProfile field: test string with apostrophes is handled correctly in a field update #497

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cbe838
XProfile field: test apostrophes is handled correctly in field update
renatonascalves Apr 8, 2024
17aeb9d
Update tests
renatonascalves Apr 9, 2024
00f9eba
Update branch to test the fix
renatonascalves Apr 9, 2024
41e3039
Test with the lastest from core
renatonascalves Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
145 changes: 145 additions & 0 deletions tests/testcases/xprofile/test-data-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,108 @@ public function test_update_multiselectbox_with_empty_value() {
$this->assertEquals( $data[0]['value']['unserialized'], [] );
}

/**
* @group update_item
*
* @ticket https://buddypress.trac.wordpress.org/ticket/9127
*/
public function test_update_multiselectbox_with_apostrophe_value() {
$field_id = $this->bp_factory->xprofile_field->create(
[
'type' => 'multiselectbox',
'field_group_id' => $this->group_id
]
);
xprofile_insert_field(
[
'field_group_id' => $this->group_id,
'parent_id' => $field_id,
'type' => 'option',
'name' => 'Option 1',
]
);

xprofile_insert_field(
[
'field_group_id' => $this->group_id,
'parent_id' => $field_id,
'type' => 'option',
'name' => "I don't travel often",
]
);

$this->bp->set_current_user( $this->user );

$request = new WP_REST_Request( 'POST', sprintf( $this->endpoint_url . '%d/data/%d', $field_id, $this->user ) );
$request->add_header( 'content-type', 'application/json' );

$params = $this->set_field_data( [ 'value' => "I don\'t travel often" ] );

$request->set_param( 'context', 'edit' );
$request->set_body( wp_json_encode( $params ) );
$response = $this->server->dispatch( $request );

$this->assertNotInstanceOf( 'WP_Error', $response );
$this->assertEquals( 200, $response->get_status() );

$data = $response->get_data();
$this->assertNotEmpty( $data );

$this->assertEquals( $data[0]['value']['unserialized'], [ "I don\'t travel often" ] );
$this->assertEquals( $data[0]['value']['raw'], "a:1:{i:0;s:21:\"I don\\'t travel often\";}" );
}

/**
* @group update_item
*
* @ticket https://buddypress.trac.wordpress.org/ticket/9127
*/
public function test_update_checkbox_with_apostrophe_value() {
$field_id = $this->bp_factory->xprofile_field->create(
[
'type' => 'checkbox',
'field_group_id' => $this->group_id
]
);
xprofile_insert_field(
[
'field_group_id' => $this->group_id,
'parent_id' => $field_id,
'type' => 'option',
'name' => 'Option 1',
]
);

xprofile_insert_field(
[
'field_group_id' => $this->group_id,
'parent_id' => $field_id,
'type' => 'option',
'name' => "I don't travel often",
]
);

$this->bp->set_current_user( $this->user );

$request = new WP_REST_Request( 'POST', sprintf( $this->endpoint_url . '%d/data/%d', $field_id, $this->user ) );
$request->add_header( 'content-type', 'application/json' );

$params = $this->set_field_data( [ 'value' => "I don\'t travel often" ] );

$request->set_param( 'context', 'edit' );
$request->set_body( wp_json_encode( $params ) );
$response = $this->server->dispatch( $request );

$this->assertNotInstanceOf( 'WP_Error', $response );
$this->assertEquals( 200, $response->get_status() );

$data = $response->get_data();
$this->assertNotEmpty( $data );

$this->assertEquals( $data[0]['value']['unserialized'], [ "I don\'t travel often" ] );
$this->assertEquals( $data[0]['value']['raw'], "a:1:{i:0;s:21:\"I don\\'t travel often\";}" );
}

/**
* @group update_item
*/
Expand Down Expand Up @@ -312,6 +414,49 @@ public function test_update_textbox() {
$this->assertEquals( $data[0]['value']['raw'], 'textbox field' );
}

/**
* @group update_item
*
* @ticket https://buddypress.trac.wordpress.org/ticket/9127
*/
public function test_update_textbox_with_apostrophe_value() {
$field_id = $this->bp_factory->xprofile_field->create(
[
'type' => 'textbox',
'field_group_id' => $this->group_id,
'value' => 'textbox field',
]
);

$this->bp->set_current_user( $this->user );

$request = new WP_REST_Request( 'POST', sprintf( $this->endpoint_url . '%d/data/%d', $field_id, $this->user ) );
$request->add_header( 'content-type', 'application/json' );

$params = $this->set_field_data( [ 'value' => "I don't travel often" ] );
$request->set_param( 'context', 'edit' );
$request->set_body( wp_json_encode( $params ) );
$response = $this->server->dispatch( $request );

$data = $response->get_data();

$this->assertNotEmpty( $data );
$this->assertEquals( $data[0]['value']['raw'], "I don't travel often" );

$request = new WP_REST_Request( 'POST', sprintf( $this->endpoint_url . '%d/data/%d', $field_id, $this->user ) );
$request->add_header( 'content-type', 'application/json' );

$params = $this->set_field_data( [ 'value' => "I don\\'t travel often" ] );
$request->set_param( 'context', 'edit' );
$request->set_body( wp_json_encode( $params ) );
$response = $this->server->dispatch( $request );

$data = $response->get_data();

$this->assertNotEmpty( $data );
$this->assertEquals( $data[0]['value']['raw'], "I don't travel often" );
}

/**
* @group update_item
*/
Expand Down