Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages: avoid a PHP Warning when getting a recipient's display_name #498

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

renatonascalves
Copy link
Member

@renatonascalves renatonascalves commented Apr 8, 2024

PHP Warning: Attempt to read property "display_name" on bool in /wp-content/plugins/buddypress/bp-messages/classes/class-bp-rest-messages-endpoint.php on line 879.

If the user query fails, one can get this PHP warning even though it returns an empty string due to the PHP typecasting.

So let's avoid this one warning.

Tickets:

@renatonascalves renatonascalves merged commit 9b5460b into master Apr 12, 2024
8 checks passed
@renatonascalves renatonascalves deleted the feature/messages-php-warning branch April 12, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant