Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizable slugs to Group views #10

Merged
merged 9 commits into from Aug 20, 2021
Merged

Conversation

imath
Copy link
Member

@imath imath commented Aug 19, 2021

Description

Group creation steps, Group front views and Group admin views can now enjoy customizable slugs. New settings has been added to the Settings > BuddyPress > URLs Administration screen to let the admin customize the slugs.
The rewrite rule used for the create group action has been improved to eventually use the slug customized by the admin user. Template URL filters / rewrite & notification functions have been updated to eventually use the customized slugs.

How has this been tested?

I've tested the changes manually checking customizing each view slugs and testing each view displays the right content.

Screenshots

screenshot

Types of changes

New feature including backward compatibility preserving the legacy BP globals.
Fixes #1

Checklist:

  • My code is tested.
  • My code is back compatible with PHP 5.6.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@imath imath added the @todo Something has to be done label Aug 19, 2021
@imath imath added this to the 1.0.0 milestone Aug 19, 2021
@imath imath self-assigned this Aug 19, 2021
@imath imath merged commit c557456 into trunk Aug 20, 2021
@imath imath deleted the try/customize-group-slugs branch August 20, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@todo Something has to be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groups single item main navigation slugs should be customizable
1 participant