Use WP Emojis in Messages subject, excerpt & content #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update some Nouveau templates/ajax function to make sure these WP Emojis are rightly rendered.
imath
added a commit
to imath/BP-REST
that referenced
this pull request
Jul 1, 2023
Instead of applying `wp_staticize_emoji` to subject and content which was ending up being stripped by the `wp_filter_kses` callback applied to the message subject template, move `wp_staticize_emoji` use inside BuddyPress core as a Messages filter. See buddypress/buddypress#123 Fixes buddypress#485
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Jul 28, 2023
- Add filters to subject, excerpt & content template functions using the `wp_staticize_emoji` callback. - Update some Nouveau templates/ajax functions to make sure these WP Emojis are rightly rendered. Props niftythree Fixes #8928 Closes buddypress/buddypress#123 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13510 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wp_staticize_emojicallback.Trac ticket: https://buddypress.trac.wordpress.org/ticket/8928
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.