Improve the Group Extension Rewrites support #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Jul 28, 2023
The `BP_Group_Extension::init()` $args parameter (array) now accepts a new argument: `$show_tab_callback`. You can use this argument to inform about the callback function to use to check whether the Extension group's tab should be displayed or not. This callback function is called inside the `BP_Group_Extension::setup_access_settings()` to make sure to set the `$show_tab` argument once the current group has been defined by BuddyPress. Third party plugin authors are strongly encouraged to use this new argument if they used to define the `$show_tab` argument according to the result of a function. Doing so in BuddyPress 12.0.0 won't make your extension behave as expected. Fixes #8943 Closes buddypress/buddypress#136 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13524 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve how the group tab display is performed to take in account Plugins using a function to set its visibility.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/8943
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.