Bring back Logged-in Member WP Nav Menu #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `'bp_parse_query'` is not fired inside WP Admin context, we need to use the `bp_get_component_navigations()` function instead of trying to access the Members primary `BP_Core_Nav`
imath
commented
Aug 10, 2023
| 'slug' => $member_navigation['main_nav']['slug'], | ||
| 'link' => bp_loggedin_user_url( | ||
| array( | ||
| 'single_item_component' => $member_navigation['main_nav']['slug'], |
There was a problem hiding this comment.
The bp_rewrites_get_slug() should be used to make sure slug customization can happen.
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Aug 23, 2023
When BP Rewrites are on, we need to use `bp_get_component_navigations()` to get the registered logged-in member's navigation items. Props vapvarun Fixes #8971 Closes buddypress/buddypress#148 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13547 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
'bp_parse_query'is not fired inside WP Admin context, we need to use thebp_get_component_navigations()function instead of trying to access the Members primaryBP_Core_Nav.Trac ticket: https://buddypress.trac.wordpress.org/ticket/8971
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.