Introduce bp_nouveau_activity_comment_data_attribute_id()
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is outputting the `data-bp-activity-comment-id` attribute. It was created as a replacement of `bp_nouveau_activity_data_attribute_id()` for the `activity/comment.php` template to avoid messing with activity types when not set (instead a requerying for the parent activity).
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Dec 12, 2023
In BP Nouveau, instead of using the same function to output the `bp-activity-comment-id` or `bp-activity-id` data attribute according to the activity type, introduce the `bp_nouveau_activity_comment_data_attribute_id()` function and use it inside the `activity/comment.php` template. This prevents a notice warning notice and avoid to query for the parent activity to get the right activity type. Props vapvarun Fixes #9014 Closes buddypress/buddypress#182 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13631 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is outputting the
data-bp-activity-comment-idattribute. It was created as a replacement ofbp_nouveau_activity_data_attribute_id()for theactivity/comment.phptemplate to avoid messing with activity types when not set (instead a requerying for the parent activity).Trac ticket: https://buddypress.trac.wordpress.org/ticket/9014
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.