Include 12.0 deprecated functions for new installs

[imath]

• Include 12.0 deprecated functions for new installs.
• Add an Admin Notification about 12.0 for new installs.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/9015

---

This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.

[imath]

Hi @dcavins

Could you have a look at the notification text and eventually fix some of my english mistakes and/or improve it ? Thanks in advance.

I've just tested the PR and I confirm 12.0 deprecated functions are loaded even if it's a new BuddyPress install. Here's a screenshot of the Admin notification.

I have mixed feelings about this Admin Notification because for new installs the "Hello BuddyPress" dialog's popping to inform about what's new. As a result, unless Administrators don't read this dialog, adding an Admin Notification might make some of them feel like "BuddyPress really wants me to install the BP Classic plugin".

@dcavins what do you think? Are we repeating ourselves with this Admin Notification ?

[dcavins]

Hmm, no I don't think we're repeating ourselves, but we might re-word the notice a little to be more "if you're site is borked, try Classic before freaking out" Maybe:
BuddyPress 12 introduces major core changes, overhauling the way that BuddyPress builds and parses URLs. If you find that your site is not working correctly with the new version, try installing the new BP Classic Add-on that adds backward compatibility for plugins and themes that have not yet been updated to work with BP 12. Thanks!

[imath]

Awesome, thanks for your reply, I'll update the notice this way 👍