Optimize BP Nouveau for Twenty Twenty-four #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use theme.json to get contentSize for the cover image width Make sure to load BP Email customizer panel Use 2024 border radius in buttons & cover image
Use a theme compat feature to make it easier to disallow/allow.
boonebgorges
pushed a commit
that referenced
this pull request
Nov 27, 2023
NB : this feature is also only available in the BP Nouveau template pack. The Priority Navigations theme compat feature is used to make sure BP Single items primary and secondary navigations are displayed on a single row/line no matter how many items these navigations are containing. When there's not enough space to display all the items on this row/line, an ellipsis is inserted and hovering on it shows the remaining nav items into a dropdown menu. This commit also make sure the BP Customizer sections are neutralized so that the Customizer is not loaded on front-end when a Block Theme is active to start complying with the fact these kind of themes are not using the Customizer. See #9030 See #197 git-svn-id: https://buddypress.svn.wordpress.org/trunk@13652 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Dec 12, 2023
NB : this feature is also only available in the BP Nouveau template pack. The Priority Navigations theme compat feature is used to make sure BP Single items primary and secondary navigations are displayed on a single row/line no matter how many items these navigations are containing. When there's not enough space to display all the items on this row/line, an ellipsis is inserted and hovering on it shows the remaining nav items into a dropdown menu. This commit also make sure the BP Customizer sections are neutralized so that the Customizer is not loaded on front-end when a Block Theme is active to start complying with the fact these kind of themes are not using the Customizer. See #9030 See buddypress/buddypress#197 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13652 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Dec 12, 2023
This new companion stylesheet improves the way BP Nouveau integrates with the latest WordPress default theme (the one bundled with version 6.4). Fixes #9030 Closes buddypress/buddypress#197 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13653 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize BP Nouveau for Twenty Twenty-four
The above screenshot shows the BP Priority Nav theme compat feature.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9030
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.