Plugin: Misc updates #210
Closed
Plugin: Misc updates #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@renatonascalves I'm also playing into this area updating Node to the one WordPress uses (20.10.0). See #205 I don't think it conflicts, it's just FYI |
|
@renatonascalves It's up to you, you can SVN commit it and I'll rebase my PR once done, or I'm fine with bundling it 👍 |
|
@renatonascalves I changed my mind, as I'm ready to commit #205 I'll bundle this PR in it. Thanks a lot for your contributions about it. |
|
@imath No problem at all. Thanks! 🙌🏾 |
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Feb 8, 2024
Following WordPress latest move, we're updating Node.js as well as some development dependencies. See: https://make.wordpress.org/core/2023/12/20/updating-wordpress-to-use-more-modern-versions-of-node-js-npm-2/ This commit also bumps PHP version to 8.2 for the coding standards GitHub action and `wp-phpunit/wp-phpunit` to 6.4 into our `composer.json` file. Props espellcaste Fixes #9047 Closes buddypress/buddypress#205 Closes buddypress/buddypress#210 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13684 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.