Avoid infinite redirections after clicking on an activity permalink when using plain permalink structure #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…displaying single screen
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Feb 8, 2024
When building the URL to redirect a single activity request to the member's activity single view, make sure to remove potential BP URI query variables relative to the Activity component before trying to transport extra query variables to the redirect URL. Props johnjamesjacoby See #9082 Closes buddypress/buddypress#225 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13714 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove potential BP URI query variables from activity permalink when redirecting to the activity single screen.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9082
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.