Use only one site-health-info panel to list BP Settings & Constants #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatonascalves
requested changes
Mar 2, 2024
| @@ -1140,6 +1146,20 @@ function bp_core_admin_debug_information_add_help_tab() { | |||
| if ( document.readyState === "complete" ) { | |||
| bpHelpSidebarLinks = document.querySelector( \'.bp-help-sidebar-links\' ).closest( \'p\') | |||
| bpHelpSidebarLinks.style.display = \'none\'; | |||
|
|
|||
| document.querySelectorAll( \'#health-check-accordion-block-buddypress tr > td\' ).forEach( function( td, i ) { | |||
There was a problem hiding this comment.
That's a nice hack! I initially looked for a way to do this without using js and could not find it.
| 'value' => defined( 'BP_SEARCH_SLUG' ) ? BP_SEARCH_SLUG : __( 'Undefined', 'buddypress' ), | ||
| 'debug' => defined( 'BP_SEARCH_SLUG' ) ? BP_SEARCH_SLUG : 'undefined', | ||
| ), | ||
| $bp_settings, |
There was a problem hiding this comment.
Unrelated to this change, but I noticed some values are really weird when copying the values.
There was a problem hiding this comment.
I don't remember very well, but I might have added these exclamation marks because of the way these options are formulated / handled inside BuddyPress. Without the exclamation mark for example: bp-disable-avatar-uploads: Yes would mean avatar uploads are disabled but I don't think it's the case. I'll look at i more closely.
There was a problem hiding this comment.
Do we save the "Yes" string in the database? If not, we should add the actual value for the copied version.
These fields are just used to separate Settings and Constants into the BuddyPress site-heath-info panel.
|
OK, I took a look and if one were to do a copy and paste into a text file the results for 2 panels makes more sense and aesthetically more pleasing (clear distinction as to the identification of BP constants). See the below between Single Panel vs Double Panel: Single PanelDouble Panel |
|
Thanks for your feedback @emaralive. Let's leave it the way it is then 👍. We'll see with user feedbacks if I was worrying for nothing 😉. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use only one site-health-info panel to list BP Settings & Constants
Trac ticket: https://buddypress.trac.wordpress.org/ticket/9101
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.