-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate per node factory url for genurl
commands
#211
Comments
I think a flag should also be added to the talosctl upgrade -n <machine1> --image $(talhelper genurl installer -n <machine1>) Alternatively, an even nicer approach would be a talhelper gencommand upgrade | bash With a This could also be expanded to handle the I think this would simplify the workflow, allowing us to just do: talhelper genconfig;
talhelper gencommand apply | bash to handle the initial bootstrap and respectively talhelper gencommand upgrade | bash Whenever we need to upgrade the OS |
@mirceanton Thanks! Really good suggestion. Do u think I should do both |
@budimanjojo Given that the talosctl upgrade \
--node <machine1> \
--image $(talhelper genurl installer --node <machine1>) \
--wait=false \
--force=true \
--reboot-mode=powercycle
talosctl upgrade \
--node <machine2> \
--image $(talhelper genurl installer --node <machine2>) \
--wait=true I think this would be easier and more maintainable than trying to implement a way to pass in flags per-node to While most users will likely be fine with the |
I'll add |
@budimanjojo Thanks! Should I open a new issue for the |
@mirceanton yes please do! |
Right now,
talhelper genurl iso
andtalhelper genurl installer
doesn't actually generate the url based on what you put intalconfig.yaml
file. It makes more sense if the generated urls can be taken from config file. Let's say I have this block inside mytalconfig.yaml
:And when I run
talhelper genurl installer
from a path where thetalconfig.yaml
is found, it should return something like this:But, when I run the
talhelper genurl installer
where there's notalconfig.yaml
found, it shouldn't error out. Instead return something like this:This change will affect
--extension
and--kernel-args
flags to be ignored whentalconfig.yaml
is found because you want to use the ones defined in the config file instead.This will make upgrading Talos using
talosctl upgrade
so much easier, i.e you want to update machine1, you will run:where the
--image
is gotten from thetalhelper genurl installer
command above.The text was updated successfully, but these errors were encountered: