Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual support #108

Closed
boydkelly opened this issue May 23, 2018 · 6 comments
Closed

Multilingual support #108

boydkelly opened this issue May 23, 2018 · 6 comments

Comments

@boydkelly
Copy link

boydkelly commented May 23, 2018

Will this be coming one day? It would be awesome addition. Thanks.

@jan-xyz
Copy link
Contributor

jan-xyz commented Aug 25, 2018

I would be interested as well, I'm looking in to this right now. I like that Ananke is really basic and not so bloated like the other themes especially the ones supporting multilingual content. All it needs for me right now is provide a language picker in the menu or side-bar.

I'm trying to figure out how themes and templates work. If you have good resources to look things up, I'd be happy to write a PR. The official documentation is really basic and doesn't really help.

@jan-xyz
Copy link
Contributor

jan-xyz commented Aug 25, 2018

I created a fork of your repository and started looking deeper into the theme stuff and it worked :) I also have to row back on my statement that the documentation doesn't help. I mostly copied stuff from the documentation and adjusted it to fit the overall appearance of the theme. It's still WIP but I think it can be helpful for others looking into it. I am also open to other suggestions and would be happy to get this into the main theme!

@jan-xyz
Copy link
Contributor

jan-xyz commented Feb 17, 2019

Partial multi language support was merged into master with #144.

@budparr what is your opinion regarding localization of strings? I could implement something like this with a PR. I do think, however, that it will be an ongoing effort with adding more localizations in the future.

@budparr
Copy link
Member

budparr commented Feb 17, 2019

@jan-xyz I'd like to make this a truly multi-lingual theme, so your contribution would be welcome.

With a little bit of care, it can be multi-lingual without upsetting those who come into the theme with one language. I will chat more about that with @regisphilibert

@jan-xyz
Copy link
Contributor

jan-xyz commented Feb 18, 2019

Sounds good. I would suggest to aim for a solution that looks the same as it is right now as a default and everything else is an add-on.

@jan-xyz
Copy link
Contributor

jan-xyz commented Feb 28, 2019

@budparr, I think this can be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants