Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator doesn't manage to boot in time in case of CI scenarios #4

Closed
andrcuns opened this issue May 15, 2017 · 4 comments
Closed

Emulator doesn't manage to boot in time in case of CI scenarios #4

andrcuns opened this issue May 15, 2017 · 4 comments

Comments

@andrcuns
Copy link
Contributor

In case if this container is used in some sort of CI setup for automated test execution, tests start executing before the android in emulator is actually booted up.
It is possible to delay test execution within test set up it self but would not be so convenient if deploying multiple containers with selenium grid via docker-compose for example.
Would You consider adding a check for avd boot_complete during container start?

@elgalu
Copy link
Contributor

elgalu commented May 15, 2017

SGTM 👍 What I do in docker-selenium is to

docker exec grid wait_all_done 10s

This will active wait up to 10 seconds for the container to be ready for tests but will finish as soon as is ready. This script can also be used as a HEALTHCHECK instruction.

So you guys could do something similar for this image, e.g.

docker exec android-container healthcheck.sh 1m

And inside that healthcheck.sh you put all the logic to wait for what's needed, avd boot_complete and so on.

So users can be sure that after that the container is ready to be used for testing.

@budtmo
Copy link
Owner

budtmo commented May 15, 2017

could you maybe help me to fix this issue? @andrcuns

@andrcuns
Copy link
Contributor Author

I have some ideas based on @elgalu excellent suggestion. I will try to test it out :)

@budtmo
Copy link
Owner

budtmo commented May 19, 2017

I will close this PR, I have already included the implementation in release 0.5

@budtmo budtmo closed this as completed May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants