Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container health check based on Android Emulator boot completion #5

Merged
merged 1 commit into from
May 15, 2017
Merged

Container health check based on Android Emulator boot completion #5

merged 1 commit into from
May 15, 2017

Conversation

andrcuns
Copy link
Contributor

Health check that should help with #4

@codecov-io
Copy link

codecov-io commented May 15, 2017

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files           2        2           
  Lines          87       87           
=======================================
  Hits           86       86           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7639375...a7c9be6. Read the comment docs.

@budtmo
Copy link
Owner

budtmo commented May 15, 2017

nice PR @andrcuns! How do you check if UI test is ready to run on running healthy container? do you put logic like docker ps | grep "something" and then if status is healthy then run UI test? because it might be helpful for others.

@andrcuns
Copy link
Contributor Author

andrcuns commented May 15, 2017

In our particular case we have a project that uses gradle as a build tool and I utilize docker-compose-gradle-plugin which has functionality for health check built in.
Can't much comment on any other solution as this project is the first one for me where I use docker containers.
But I would assume that polling for status either via docker ps or docker inspect should work. Or quick google search shows that this will work in getting it in json format: docker inspect --format='{{json .State.Health}}' your-container-name

@budtmo
Copy link
Owner

budtmo commented May 15, 2017

I will merge it and include this fix to next release.

@budtmo budtmo merged commit 81e63fb into budtmo:master May 15, 2017
@andrcuns andrcuns deleted the container_health_check branch May 15, 2017 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants