Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crates using skeptic are recompiled no matter what #25

Closed
torkleyy opened this issue May 12, 2017 · 2 comments
Closed

Crates using skeptic are recompiled no matter what #25

torkleyy opened this issue May 12, 2017 · 2 comments

Comments

@torkleyy
Copy link

Even though I didn't modify anything, the crate gets recompiled. I don't think I'm the only one facing this issue: kvark/froggy#26

@steveatinfincia
Copy link

Just noticed this as well, we have a Visual Studio project that includes several Rust/Cargo sub-projects. Each one uses a crate that depends on skeptic, so even though nothing has changed in the Rust code or the dependencies, it take a full minute for each of them to build before the main project can build+run during development.

Perhaps a quick fix for crates using skeptic would be to put it behind a default feature flag that can be disabled, though I'm not sure what the root cause is.

@bozaro
Copy link

bozaro commented Jun 23, 2017

Root cause: rust-lang/cargo#4213

jpastuszek added a commit to jpastuszek/liquid-rust that referenced this issue Sep 22, 2017
jpastuszek added a commit to jpastuszek/liquid-rust that referenced this issue Sep 22, 2017
Build script calls skeptic which emits information asking cargo to monitor
content of README.md.skt.md for changes. If changes to that file are
detected cargo should rebuild liquid crate.
In case of this project the files does not exist. This causes
cargo to trigger a rebuild every time in hope that it will get crated by
the build script.
The workaround is to crate the file that skeptic asks to monitor which
stops cargo from triggering the rebuild.

For details consult this issues:

* budziq/rust-skeptic#25
* rust-lang/cargo#4213
jpastuszek added a commit to jpastuszek/liquid-rust that referenced this issue Sep 22, 2017
Build script calls skeptic which emits information asking cargo to monitor
content of README.md.skt.md for changes. If changes to that file are
detected cargo should rebuild liquid crate.
In case of this project the files does not exist. This causes
cargo to trigger a rebuild every time in hope that it will get created by
the build script.
The workaround is to create the file that skeptic asks to monitor which
stops cargo from triggering the rebuild.

For details consult this issues:

* budziq/rust-skeptic#25
* rust-lang/cargo#4213
epage added a commit to epage/assert_cli that referenced this issue Sep 24, 2017
Build script calls skeptic which emits information asking cargo to
monitor content of README.md.skt.md for changes. If changes to that file
are detected cargo should rebuild this crate.  In case of this project
the files does not exist. This causes cargo to trigger a rebuild every
time in hope that it will get created by the build script.

The workaround is to create the file that skeptic asks to monitor which
stops cargo from triggering the rebuild.

For details consult this issues:

* budziq/rust-skeptic#25
* rust-lang/cargo#4213
bors bot added a commit to assert-rs/assert_cli that referenced this issue Sep 24, 2017
40: Reduce needless recompiles r=epage a=epage

Build script calls skeptic which emits information asking cargo to
monitor content of README.md.skt.md for changes. If changes to that file
are detected cargo should rebuild this crate.  In case of this project
the files does not exist. This causes cargo to trigger a rebuild every
time in hope that it will get created by the build script.

The workaround is to create the file that skeptic asks to monitor which
stops cargo from triggering the rebuild.

For details consult this issues:

* budziq/rust-skeptic#25
* rust-lang/cargo#4213
mbrubeck added a commit to mbrubeck/rust-skeptic that referenced this issue Oct 26, 2017
budziq pushed a commit that referenced this issue Oct 27, 2017
jorenvo added a commit to jorenvo/ply-rs that referenced this issue Jan 23, 2018
skeptic causes cargo to monitor README.md.skt.md. This file does not
exist, nor is it created by any build script. Because of this cargo
will always rebuild.

Inspired by:
assert-rs/assert_cli@ccc8af5

More info:
budziq/rust-skeptic#25
rust-lang/cargo#4213
jorenvo added a commit to jorenvo/ply-rs that referenced this issue Jan 23, 2018
skeptic causes cargo to monitor README.md.skt.md. This file does not
exist, nor is it created by any build script. Because of this cargo
will always rebuild:

$ RUST_LOG=cargo::ops::cargo_rustc::fingerprint=info cargo build
... stale: /home/jvo/.cargo/registry/src/github.com-1ecc6299db9ec823/ply-rs-0.1.1/README.md.skt.md -- missing
... fingerprint error for ply-rs v0.1.1: mtime based components have changed

Inspired by:
assert-rs/assert_cli@ccc8af5

More info:
budziq/rust-skeptic#25
rust-lang/cargo#4213
jorenvo added a commit to jorenvo/ply-rs that referenced this issue Jan 23, 2018
skeptic causes cargo to monitor README.md.skt.md. This file does not
exist, nor is it created by any build script. Because of this cargo
will always rebuild:

$ RUST_LOG=cargo::ops::cargo_rustc::fingerprint=info cargo build
... stale: /home/.../ply-rs-0.1.1/README.md.skt.md -- missing
... fingerprint error for ply-rs v0.1.1: mtime based components have changed

Inspired by:
assert-rs/assert_cli@ccc8af5

More info:
budziq/rust-skeptic#25
rust-lang/cargo#4213
jorenvo added a commit to jorenvo/ply-rs that referenced this issue Jan 23, 2018
skeptic causes cargo to monitor README.md.skt.md. This file does not
exist, nor is it created by any build script. Because of this cargo
will always rebuild even if nothing has been changed:

$ RUST_LOG=cargo::ops::cargo_rustc::fingerprint=info cargo build
... stale: /home/.../ply-rs-0.1.1/README.md.skt.md -- missing
... fingerprint error for ply-rs v0.1.1: mtime based components have changed

Inspired by:
assert-rs/assert_cli@ccc8af5

More info:
budziq/rust-skeptic#25
rust-lang/cargo#4213
jorenvo added a commit to jorenvo/ply-rs that referenced this issue Jan 23, 2018
skeptic causes cargo to monitor README.md.skt.md. This file does not
exist, nor is it created by any build script. Because of this cargo
will always rebuild even if nothing has changed:

$ RUST_LOG=cargo::ops::cargo_rustc::fingerprint=info cargo build
... stale: /home/.../ply-rs-0.1.1/README.md.skt.md -- missing
... fingerprint error for ply-rs v0.1.1: mtime based components have changed

Inspired by:
assert-rs/assert_cli@ccc8af5

More info:
budziq/rust-skeptic#25
rust-lang/cargo#4213
jorenvo added a commit to jorenvo/ply-rs that referenced this issue Jan 23, 2018
skeptic causes cargo to monitor README.md.skt.md. This file does not
exist, nor is it created by any build script. Because of this cargo
will always rebuild even if nothing has changed:

$ RUST_LOG=cargo::ops::cargo_rustc::fingerprint=info cargo build
... stale: /home/.../ply-rs-0.1.1/README.md.skt.md -- missing
... fingerprint error for ply-rs v0.1.1: mtime based components have changed
Compiling ply-rs v0.1.1
...
Finished dev [unoptimized + debuginfo] target(s) in 6.90 secs
$ RUST_LOG=cargo::ops::cargo_rustc::fingerprint=info cargo build
... stale: /home/.../ply-rs-0.1.1/README.md.skt.md -- missing
... fingerprint error for ply-rs v0.1.1: mtime based components have changed
Compiling ply-rs v0.1.1
...
Finished dev [unoptimized + debuginfo] target(s) in 6.81 secs

Inspired by:
assert-rs/assert_cli@ccc8af5

More info:
budziq/rust-skeptic#25
rust-lang/cargo#4213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants