Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination ellipsis behavior #1529

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Conversation

service-paradis
Copy link
Collaborator

@service-paradis service-paradis commented Jul 3, 2019

Fixes #1321

This fix the case where the ellipsis were shown with only one item to hide.

Display
image
Instead of
image


Display
image
Instead of
image

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #1529 into dev will increase coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1529      +/-   ##
==========================================
+ Coverage   44.41%   44.43%   +0.01%     
==========================================
  Files          48       48              
  Lines        1720     1724       +4     
  Branches      559      551       -8     
==========================================
+ Hits          764      766       +2     
- Misses        874      876       +2     
  Partials       82       82
Impacted Files Coverage Δ
src/components/pagination/Pagination.vue 41.86% <75%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb293a...8047eaa. Read the comment docs.

@jtommy
Copy link
Member

jtommy commented Jul 5, 2019

Thanks, it's a little breaking change so i'll merge it on 0.8.0

@jtommy jtommy merged commit dfa6e76 into buefy:dev Jul 17, 2019
@jtommy
Copy link
Member

jtommy commented Jul 17, 2019

Thanks a lot! The new 0.8.0 contains only your PR 🎉

@service-paradis
Copy link
Collaborator Author

Loving Buefy as you can see :)
Happy to help you out improving it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination bad behavior
2 participants